Skip to content

Vtadmin2 - #20946

Open
thealish wants to merge 29 commits into
vitessio:mainfrom
thealish:vtadmin2
Open

Vtadmin2#20946
thealish wants to merge 29 commits into
vitessio:mainfrom
thealish:vtadmin2

Conversation

@thealish

@thealish thealish commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Description

Related Issue(s)

#20107

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • [:heavy_check_mark: ] Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

AI Disclosure

I have used GLM 5.3-flash extensively for UI work and for tests

mattlord and others added 11 commits August 30, 2026 00:16
@mattlord @thealish
vtadmin2 PoC
9347023 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord @thealish
Add vtadmin2 to local examples
a421bbc 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord @thealish
Add logo and use primary color
712a362 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord @thealish
Address review comments
b51d06c 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord @thealish
Address codex review comments
1c0e1e6 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord @thealish
Build out read-only parity with vtadmin
2e70f27 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord @thealish
Various tweaks and improvements from local testing
acc6dfc 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord @thealish
Address copilot review comments
50917f6 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord @thealish
Minor fixes
e3014d4 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@thealish
vtadmin: add server-rendered admin UI
d530e72 
Signed-off-by: Alisher <thealishh@gmail.com>
@thealish
vtadmin: use encoding/json/v2
d7a70d3 
Signed-off-by: Alisher <thealishh@gmail.com>
Copilot AI balanced review requested due to automatic review settings August 29, 2026 19:25
@vitess-bot vitess-bot Bot added NeedsWebsiteDocsUpdate What it says NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Aug 29, 2026
@github-actions github-actions Bot added this to the v25.0.0 milestone Aug 29, 2026
@vitess-bot

vitess-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

chatgpt-codex-connector[bot]

This comment was marked as resolved.

Sign in to view

@promptless

promptless Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Promptless documentation updates

@thealish
vtadmin2: fix review follow-ups for auth, cookies, and workflow actions
57462af 
Tighten VDiff/reload-schema authorization, treat unauthorized failover as a denial, and ship the remaining UI correctness and packaging fixes from the vtadmin2 review.

Signed-off-by: Alisher <thealishh@gmail.com>
Copilot AI review requested due to automatic review settings September 2, 2026 15:28
Copilot AI review requested due to automatic review settings September 3, 2026 14:40
chatgpt-codex-connector[bot]

This comment was marked as resolved.

Sign in to view

thealish and others added 2 commits September 3, 2026 19:45
@thealish @cursoragent
fix UI shutdown topology and CSRF review issues
cf6f2d2 
Signed-off-by: Alisher <thealishh@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@thealish @cursoragent
reject cross-origin CSRF submissions
91c44b8 
Signed-off-by: Alisher <thealishh@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

This comment was marked as resolved.

Sign in to view

Copilot AI review requested due to automatic review settings September 3, 2026 14:56

This comment was marked as resolved.

Sign in to view

@thealish @cursoragent
fix shard validation and schema reload defaults
50bc489 
Signed-off-by: Alisher <thealishh@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI review requested due to automatic review settings September 3, 2026 15:04
@thealish @cursoragent
avoid Unix signal in integrated UI shutdown
44a4669 
Signed-off-by: Alisher <thealishh@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@thealish @cursoragent
isolate unrelated cluster errors in form loading
5cce308 
Signed-off-by: Alisher <thealishh@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI reviewed Sep 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Multi-cluster forms retain keyspaces from the previously selected cluster, preventing several operations from targeting another cluster correctly.

Review details

Suppressed comments (6)

Previously missed (6) — in code that hasn't changed since the last review.

go/vt/vtadmin/vtadmin2/templates/migrations.html:28

  • Changing the cluster leaves this select populated with keyspaces from the previously rendered cluster. Because no client-side code updates dependent selects, the request pairs the new cluster with the old cluster's keyspace, making migrations on non-default clusters inaccessible through the form. Please make cluster selection reload the keyspaces first or update the options dynamically.
    go/vt/vtadmin/vtadmin2/templates/transactions.html:25
  • Changing the cluster does not refresh this keyspace select: it contains only keyspaces from the cluster selected when the page was rendered, and the shipped JavaScript has no dependent-select handler. In a multi-cluster deployment, submitting a different cluster therefore sends a keyspace from the previous cluster, so users cannot select/query the new cluster through this form. Please add a two-step cluster selection or update the keyspace options when the cluster changes.
    go/vt/vtadmin/vtadmin2/templates/vexplain.html:24
  • This dropdown is rendered only for the current cluster, but changing the cluster dropdown does not repopulate it. Submitting VExplain for another cluster therefore sends the old cluster's keyspace and cannot target the selected cluster. Please implement a cluster-selection reload step or a dependent keyspace update.
    go/vt/vtadmin/vtadmin2/templates/vtexplain.html:24
  • This dropdown is rendered only for the current cluster, but changing the cluster dropdown does not repopulate it. Submitting VTExplain for another cluster therefore sends the old cluster's keyspace and cannot target the selected cluster. Please implement a cluster-selection reload step or a dependent keyspace update.
    go/vt/vtadmin/vtadmin2/templates/workflow_materialize_create.html:30
  • The source-keyspace options are restricted to the cluster selected at render time, but selecting another cluster does not update them. “Load reference tables” then submits the new cluster with a source keyspace from the old cluster, so Materialize creation cannot target a non-default cluster through the UI. Please reload the form on cluster selection or update this dependent select.
    go/vt/vtadmin/vtadmin2/templates/workflow_movetables_create.html:30
  • The source-keyspace options are restricted to the cluster selected at render time, but selecting another cluster does not update them. “Load tables” then submits the new cluster with a source keyspace from the old cluster, so a MoveTables workflow cannot be created for a non-default cluster through the UI. Please reload the form on cluster selection or update this dependent select.
  • Files reviewed: 110/111 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Copilot AI review requested due to automatic review settings September 3, 2026 15:09
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

@thealish @cursoragent
exit when integrated vtadmin2 listener fails
01f5196 
Signed-off-by: Alisher <thealishh@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI review requested due to automatic review settings September 3, 2026 15:24
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

This comment was marked as resolved.

Sign in to view

@thealish @cursoragent
harden vtadmin2 failure handling
eeb0186 
Signed-off-by: Alisher <thealishh@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Copilot AI review requested due to automatic review settings September 3, 2026 15:44
devin-ai-integration[bot]
devin-ai-integration Bot reviewed Sep 3, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 new potential issues.

Devin Review

Comment thread go/vt/vtadmin/vtadmin2/workflows_create.go
Comment thread go/vt/vtadmin/vtadmin2/workflows_actions.go
Comment thread go/vt/vtadmin/vtadmin2/security.go
Copilot AI reviewed Sep 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The broad administrative surface includes numerous destructive cluster operations and warrants final human validation.

Review details
  • Files reviewed: 112/113 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments
Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner
@mhamza15 mhamza15 Awaiting requested review from mhamza15 mhamza15 is a code owner
@frouioui frouioui Awaiting requested review from frouioui frouioui is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Component: Examples Component: VTAdmin VTadmin interface NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says

Projects

None yet

Milestone

v25.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thealish @mattlord